feat(product): Add 'product' commands for each Fastly product.#1362
Draft
kpfleming wants to merge 10 commits intofastly:mainfrom
Draft
feat(product): Add 'product' commands for each Fastly product.#1362kpfleming wants to merge 10 commits intofastly:mainfrom
kpfleming wants to merge 10 commits intofastly:mainfrom
Conversation
kpfleming
added
DO NOT MERGE YET
dependencies
cee-dub
reviewed
Dec 18, 2024
Contributor
cee-dub
left a comment
cee-dub
left a comment
There was a problem hiding this comment.
Love the test mocking. Package names could be more idiomatic.
cee-dub
reviewed
Dec 18, 2024
Contributor
Author
|
@cee-dub If you're interested, this could use a second 'structural' review; much like go-fastly, this now has an |
cee-dub
reviewed
Jan 13, 2025
kpfleming
force-pushed
the
cdtool-967
branch
from
13657b8 to
8cf280d
Compare
Adds 'enable', 'disable', and 'status' commands for each product previously supported by the 'products' command (which is now deprecated). Also adds 'configure' commands for products which support configuration (DDoS Protection and Next-Gen WAF).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 'enable', 'disable', and 'status' commands for each product previously supported by the 'products' command (which is now deprecated).
Also adds 'configure' commands for products which support configuration (DDoS Protection and Next-Gen WAF).